• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Test:

  1. Install NatSkinPlugin
  2. Put a %COMMENT % on a new page using edit
  3. Edit the page in compose. Note the comment box appears, not the tag
  4. Hit save.
  5. View raw.

The %COMMENT % has been replaced with HTML equivalent.

Tested with SVN 7456 of both Develop and WysiwygPlugin, installed with pseudo-install.


WysiwygPlugin must be the first plugin in your {PluginsOrder} list. Otherwise CommentPlugin will turn a COMMENT tag into HTML.

CC

Oooh. Yucky! But thanks wink

Hmm... Maybe we should allow plugins to announce this after being installed by pseudo-install and in FAILEDPLUGINS?

MC

It turns out that this only happens when NatSkinPlugin is installed.

MC

I was able to reproduce the error switching on and off the TwistyPlugin using only the WysiwygPlugin, CommentPlugin, TablePlugin, TwistyPlugin in this order.

Some cruft gets into the edit area: some integers and sometimes stuff that the addToHEAD() handler should have added to the head. But things sneak in deeper. May not be related but the WysiwygPlugin should use the addLoadEvent() mechanism. The TwistyPlugin and NatSkinPlugin both add javascript and load events to the header. That might be a hint on what's going on here.

Changing the "Extension" of this bug item to WysiwygPlugin.

MD

Nothing to do with the addHEAD. The problem came in two phases:

  1. There was an assumption (imported from Cairo) that the first call to the commonTagsHandler was always the call that processed the text body. Unfortunately if another plugin called addToHEAD this was no longer true. So this had to be recoded to use the body_text context id (a much better approach anyway)
  2. Then I discovered that the body_text id was not being reset, so it was still active when the footer was being rendered.
These two problems solved in SVN 4672

CC

ItemTemplate
Summary COMMENT TAG gets turned into HTML by WysiwygPlugin if NatSkinPlugin is installed
ReportedBy MartinCleaver
SVN Range

AppliesTo Extension
Component WysiwygPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 7671 7672
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r8 - 2005-11-29 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2022 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback