• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

As stated in Item910, Dakar has lost Cairo's $dispViewPath configuration item (described as "URL path to view script used to render links, relative to $dispScriptUrlPath="), which used to allow several documented short-URLs setups to offer nice URLs that don't include the =view word.

This configuration variable was made available to templates : %VIEWPATH%.

Nevertheless, Cairo's PatternSkin templates did not use this $dispViewPath variable, but hardcoded URLs including the view word, such as https://mail.twiki.org/do/view/Bugs/Item911. That for, several documented short-URLs setups, such as boum's one, needed to patch these templates to fix this.

This has not changed in Dakar, which is quite logical since $dispViewPath configuration item has vanished.

But... Martin Cleaver asked me to package boum's short-URLs setup as a contrib alongside Dakar, which is impossible with current Dakar code due to Item910 and to this bug.

What needs to be done is :

  • reintroduce the $dispViewPath configuration item and the %VIEWPATH% template variable ;
  • run a simple find templates -name '*.tmpl' -exec perl -pi -e 's,/view,%VIEWPATH%,g' {} \; on the templates directory in order to use this configurable variable instead of hardcoding stuff.

This topic has been discussed on TWiki:Codev/ShorterURLs.


This was fixed with the introduction of {ScriptUrlPaths} in LocalSite.cfg. Discarding. CC


Not really. The introduction of {ScriptUrlPaths} was welcome, and has brought the ability not to hard-code https://mail.twiki.org/do/script in templates, but rather to use https://mail.twiki.org/do/script. Great.

But in yesterday's svn (7687), there are still some templates, such as twiki.pattern.tmpl, rdiff.pattern.tmpl, view.pattern.tmpl, that still hard-code old constructions, such as /do/view.

That's why I'm re-openning this bug, since the problem I detected for shorter-urls setups is still alive.

-- Main.BenVoui


It appears that Arthur reverted most, if not all, of the fixes I made in SVN 7429, converting %SCRIPTURL% and %SCRIPTURLPATH% to %SCRIPTURL{"..."}% in the templates. Arthur, why?

CC


If something was reverted this was not the intention. It must have happened when I reverted the new style (gray borders) back, and I must have missed the view update.

Fixed in SVN 7718.

AC


Great, but there are still a few in view.pattern.tmpl and twiki.pattern.tmpl. -- BenVoui

Last few removed in SVN 7768

CC

ItemTemplate
Summary Hardcoded /view in Pattern skin templates
ReportedBy BenVoui
SVN Range 7767
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 7718 7768
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r8 - 2005-12-05 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2022 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback