Item7740 < Bugs

• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use

Item7848 for generic doc work for TWiki-6.1.1. Use

Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Engine		Normal	Closed		patch	6.1.0

TWiki::Templates::readTemplate() calls _readTemplateFile(), which cleanses the template name. So far, a slash (/) is subject for cleansing -- slashes in a template name are removed. This makes it impossible to use a web.topic of a subweb as a template. This is a problem. For example, TWiki:Plugins/CommentPlugin

cannot use a comment template in a subweb.

So a template name needs to allow /.

In doing so, there is a bit of concern of an arbitrary file is accessed with a template name containing ../. So I put a line to replace two or more consecutive dots with one dot.

I was tempted to make / and . interchangeable in a template name. But if I do so, %TMPL:INCLUDE{"view.pattern.tmpl"}% stops working, hence I abandoned the idea.

-- TWiki:Main/HideyoImazu - 2016-04-12

ItemTemplate
Summary	TWiki::Templates::readTemplate() unable to read a topic in a subweb
ReportedBy	TWiki:Main.HideyoImazu
Codebase	~twiki4
SVN Range	TWiki-6.0.2-trunk, Wed, 23 Mar 2016, build 29999
AppliesTo	Engine
Component
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	TWikirev:30139 TWikirev:30140 TWikirev:30145 TWikirev:30146
TargetRelease	patch
ReleasedIn	6.1.0

Item7740: TWiki::Templates::readTemplate() unable to read a topic in a subweb

Item Form Data

Edit Form Data

Detail