• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

Item7643: Invalid (X)HTML created by TWiki and by skins

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Low Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TWiki in general, and skins in particular, create invalid (X)HTML in a few places.

Not a big issue for the end user, so this is just the issue to commit fixes when we stumble over them.

A few observations so far:

  • Plain skin (relevant for testing without decoration getting into the way): Invalid empty attribute class="" for the <body> tag DONE
  • Plain skin: Extra <p /> after </html> DONE
  • Pattern skin: One unclosed <div> (haven't figured out which one yet, this skin is more of an onion than a skin) DONE
  • Invalid construction of form elements: They need a block level element as content, directly having input or span is invalid. "Fixing" this is dangerous to the style sheets frown
  • Javascript snippets contain unescaped < and &
-- TWiki:Main/HaraldJoerg - 2015-04-17

"this skin is more of an onion than a skin" - haha, so true.

-- TWiki:Main.PeterThoeny - 2015-04-20

Plain skin is fixed with Rev. 30385.

-- TWiki:Main.HaraldJoerg - 2017-09-04

With regard to form elements and Javascript snippets: These are only invalid when parsing as XML, i.e. in strict XHTML mode, but according to my understanding perfectly valid in HTML5. So far, there haven't been any problem reports, and I guess "XML processing of TWiki" output has never been a valuable use case. Therefore I suggest to drop these two points and close this bug (let's discuss at a release meeting).

-- TWiki:Main.HaraldJoerg - 2017-10-03

Given that the world is moving towards HTML5 (and not XHTML) where the remaining observations are valid, I'm closing this now.

-- TWiki:Main.HaraldJoerg - 2017-11-03

ItemTemplate
Summary Invalid (X)HTML created by TWiki and by skins
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-6.0.1-trunk, Fri, 03 Apr 2015, build 28925
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins TWikirev:29098 TWikirev:29099 TWikirev:30385
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r10 - 2018-07-13 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2023 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback