Item7631 < Bugs

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Extension	PatternSkin	Low	New

The nice feature to attach files with drag'n'drop has a minor wart: Every time it is used, a line in the error log says:

ERROR: http://site/bin/Web/Topic at /home/haj/devel/twiki/trunk/core/lib/TWiki.pm line 928.

The reason is that to make it work, the template now has an additonal parameter noredirect=1, apparently to delay redirection by the upload process before all attachments have been processed. This trips over a smelly rock in TWiki.pm:

    # SMELL: if noredirect is set, don't generate the redirect, throw an
    # exception instead. This is a HACK used to support TWikiDrawPlugin.
    # It is deprecated and must be replaced by REST handlers in the plugin.
    if( $query->param( 'noredirect' )) {
        die "ERROR: $url";
        return;
    }

It seems that the new way to attach files also relies on said "HACK", only that it has no chance to use REST handlers. The question arises why the code insists on dying? I guess we could as well make it a feature.

-- TWiki:Main/HaraldJoerg - 2015-04-01

ItemTemplate
Summary	Attach with drag'n'drop writes a line to the error log every time
ReportedBy	TWiki:Main.HaraldJoerg
Codebase	~twiki4
SVN Range	TWiki-6.0.1-trunk, Sat, 21 Mar 2015, build 28827
AppliesTo	Extension
Component	PatternSkin
Priority	Low
CurrentState	New
WaitingFor
Checkins
TargetRelease
ReleasedIn

Item7631: Attach with drag'n'drop writes a line to the error log every time

Item Form Data

Edit Form Data

Detail