The fix for
Item7476 adds the concept of a $br variable to the documentation for the SEARCH newline parameter; this did not work when I tested it on my patched 6.0.0.
I also note that the changed code of TWiki::Render::protectFormFieldValue does not match the claim of its function header:
* newlines are replaced with <br> or the value of $attrs->{newline}
Specifically, the changed code does not replace newlines with <br /> when $attrs->{newline} is not present. It isn't clear to me if the header comment is wrong, or if the implementation needs to be updated to meet requirements.
--
TWiki:Main/DavidDAllen
- 2014-03-31
The code comment needs to be updated. The documentation in
VarSEARCH always stated that a missing newline parameter has no action, e.g. newlines are newlines.
--
TWiki:Main.PeterThoeny
- 2014-04-01
I tested the patch. Before the patch you got two line breaks as you reported in
Item7476, after the patch you get one line break as expected. Do I miss something?
--
TWiki:Main.PeterThoeny
- 2014-04-01
Item7476 is fixed (thanks!). As I stated above, the newly documented $br variable for the SEARCH newline parameter did not work in my testing.
--
TWiki:Main.DavidDAllen
- 2014-04-01
Confirmed.
--
TWiki:Main.PeterThoeny
- 2014-04-01
This is now fixed. I changed the summary to reflect the nature of this new mini-feature.
--
TWiki:Main.PeterThoeny
- 2014-04-01