Item7386 < Bugs

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Extension	SpreadSheetPlugin	Normal	No Action Required		n/a

The SpreadSheetPlugin currently has 4 functions that accept regular expression parameters: $FILTER(), $SEARCH(), $SPLIT(), $SUBSTITUTE().

I tried to abuse the regex with the relatively new code execution feature (?{perl code}), but did not succeed. In any case, it is better to play safe and sanitize the regular expression string before applying it.

-- TWiki:Main/PeterThoeny - 2013-11-19

Only those functions that use eval for regex need to be sanitized.

-- TWiki:Main.PeterThoeny - 2013-11-20

I am closing this with "no action required" based on http://stackoverflow.com/questions/4289923/in-which-languages-is-it-a-security-hole-to-use-user-supplied-regular-expression - you cannot execute code callbacks in Perl by sneaking them in an evaluated regex. This is forbidden. You have to specifically override that with a lexically scoped use re "eval";

-- TWiki:Main.PeterThoeny - 2014-10-04

ItemTemplate
Summary	Sanitize regular expressions
ReportedBy	TWiki:Main.PeterThoeny
Codebase	~twiki4, 6.0.0
SVN Range	TWiki-6.0.0, Mon, 14 Oct 2013, build 26523
AppliesTo	Extension
Component	SpreadSheetPlugin
Priority	Normal
CurrentState	No Action Required
WaitingFor
Checkins
TargetRelease	n/a
ReleasedIn

Item7386: Sanitize regular expressions

Item Form Data

Edit Form Data

Detail