Item5231: DirectedGraphPlugin fails in TWiki 4.2 RC2

I'm currently testing TWiki 4.2 RC2 (TWiki:Codev.TWikiRelease04x02x00rc2). DirectedGraphPlugin does not seem to work with this release. The code in DirectedGraphPlugin uses TWiki::sharedSandbox, and fails because that variable is undefined. In TWiki 4.1.2, this variable is defined in lib/TWiki.pm, around line 452. I don't see any code in TWiki 4.2 which initializes TWiki::sharedSandbox. I can't tell whether this is intentional. If it is, then the plugin needs to be updated, otherwise the TWiki code must resurrect the sharedSandbox.

Tested on a Linux box running CentOS 5.

-- TWiki:Main/ClausBrod - 09 Jan 2008

TWiki::SharedSandbox is not official API so it is the plugin that needs to be fixed and the fix should avoid abusing a new internal variable.

-- TWiki:Main.KennethLavrsen - 09 Jan 2008

Thanks, Kenneth! The plugin uses Sandbox::sysCommand, and that's why it tries to access the sharedSandbox instance. If sharedSandbox is not part of the official plugin API, what would be a good way for a plugin to proceed?

Thanks!

-- TWiki:Main.ClausBrod - 09 Jan 2008

TWiki 4.2 has a TWiki::Sandbox API - I'm assuming that that is the one to use. The plugin tries to detect which Sandbox API to use.

-- TWiki:Main.GeorgeClark - 09 Jan 2008

I didn't address this one - I have 4.2 installed, but I've been a bit lazy and testing on 4.1.2. I'll have to fire up 4.2 again. If someone else doesn't fix it I'll give it a shot. My fixes are quite extensive, and I don't have checkin authority yet, so I'm a bit hesitant on how to proceed.

-- TWiki:Main.GeorgeClark - 10 Jan 2008

The fix for the sandbox problem is fairly simple... Pulled a couple lines of code from the natskin plugin. There are other issues with 4.2 however. wysiwyg editor totally breaks the dot language. Completely destroys the page. And there were a couple of other tweaks needed but as long as I don't touch the page with wysiwyg, it works with my new code.

Er... not yet. The plugin does not seem to be picking up defaults either. It works as long as the dot command specifies the output format.

-- TWiki:Main.GeorgeClark - 10 Jan 2008

I have attached a test version of the plugin to Bugs:Item5212 that should address the Sandbox issue. It's working on RC1. caution changes are very extensive and result in different attachment file names.

-- TWiki:Main.GeorgeClark - 10 Jan 2008

My first tests goes very well on RC2. I only had to set the path to the tools directory in configure..great job George. If you dont soon get the code committed maybe attach your updates to DirectedGraphPluginDev so that others find it easily.

-- TWiki:Main.LarsEik - 10 Jan 2008

I could not open the plugin topic (DirectedGraphPlugin.txt), it said " File::Temp reference passed in INFILE at /var/www/twiki/lib/TWiki/Sandbox.pm line 264." in the warn logfile and apache error log. I think it's because some of the files from the dot examples was created before, or something. I hand-edited the plugin topic and put verbatim tags on all examples that said "You get this (if installed)" so they did not get rendered as dot code, and it looks ok now. I installed (unzipped and moved) your updates over the plugin which was already installed before. I have not tested on a TWiki that dont have TWiki:Plugins.DistributedGraphPlugin installed.

-- TWiki:Main.LarsEik - 10 Jan 2008

I'm going to have to reinstall / retest a couple of times on this one. It really shouldn't care about pre-existing files. It will just overwrite. And in the case of the previous plugin, all of the generated file names are changed. So that isn't it.

In any event, you should not have run into this, so something is not right. All of the examples in DirectedGraphPlugin should have worked just fine.

-- TWiki:Main.GeorgeClark - 11 Jan 2008

Found the problem. With antialias output I neglected to create the temporary file name for the .png file, so the convert utility received a File::Temp instead of the name provided by File::Temp. I'll attach an updated zipfile.

-- TWiki:Main.GeorgeClark - 11 Jan 2008

Now it looks fine. I had to reload apache.

-- TWiki:Main.LarsEik - 11 Jan 2008