Item5185: User mapping testcase is giving a false positive

However they are setting $TWiki::cfg{AllowLoginName} instead of $TWiki::cfg{Register}{AllowLoginName}, so have no effect.

If the correct switch is used, the tests fail.

-- TWiki:Main/CrawfordCurrie - 31 Dec 2007

bugger. I'll look at it when i have 'net, and see if it can / needs to be dealt with for the release.

-- TWiki:Main.SvenDowideit - 02 Jan 2008

All the failures appear to be in the $TWiki::cfg{Register}{AllowLoginName} = 0; case, and Why, appears to be somewhat clear when you look at the set_up_for_verify function - it was written to assume AllowLoginName = 1.

This 'problem' was caused because the FuncUser tests were not updated to work correctly for AllowLoginName = 0; I remember looking into fixing the tests a while back, but it slipped my mind

I have fixed the unit tests, and simplified the UserMapping code to resolve some issues, but we're going to have to spend some time re-testing group membership under the many different options.

-- TWiki:Main.SvenDowideit - 07 Jan 2008

Thanks Sven. I'm simplifying the tests (among other things) at the moment, as I go through implementing the TOM. Of course that only impacts MAIN

CC

I have not seen any negative effects since these check-ins. Removed my name from feedback field.

KJL

I have no idea what feedback I could give? I did not spot the error, have not contributed to the code nor to the unit tests, am never using $TWiki::cfg{Register}{AllowLoginName} = 0; nor TWiki::Func.

I can't comment on the comment in the source code either:

#login invalid... (TODO: what does that really mean)

So I'll just close the item....

-- TWiki:Main.HaraldJoerg - 11 Jan 2008

heheh I was hoping you might have time to update your installation to make sure that your use case is still ok

-- SvenDowideit - 11 Jan 2008