Item5179: Quotation marks are translated to entities destroying TWiki Applications

Minor bug only, a workaround is to get rid of the quotation marks as in

• http://develop.twiki.org/~twiki4/cgi-bin/rdiff/Bugs/WebHome?rev2=27&rev1=28&render=debug

-- TWiki:Main/SteffenPoulsen - 29 Dec 2007

Can you provide a testcase please?

-- TWiki:Main.CrawfordCurrie - 29 Dec 2007

It seems " gets entiry encoded everywhere now. Why?

Here is the test case that Steffen linked to.

Create New Report

As I paste this in there are double quotes round the word newtopic inside the ICON tag.

When I write something with "quotes" around the quites become entiry encodes. They absolutely should not be. If it was only inside the special test case Steffen gave it would be a normal bug. But with "quotation marks" encoded everywhere it is urgent release blocker. How many more characters in the plain characters with values below 128 are entity encoded??

-- TWiki:Main.KennethLavrsen - 29 Dec 2007

Oh God. This is worse than I feared. Any TWiki topic you edit gets standard straight double quotations entity encoded when you do a simple edit / save round trip.

I have put this in production two days ago and I just checked and can see several twiki application that are no longer working.

Can we have a quick fix of this please for all us RC testers? We need it badly.

-- TWiki:Main.KennethLavrsen - 29 Dec 2007

Tried all the characters my keyboard can produce. It is " & < and > that always get entity encoded.

-- TWiki:Main.KennethLavrsen - 29 Dec 2007

I changed it so it won't entity encode those characters, but I am dubious what will happen if those characters are ever used in a complex TML expression, such as a search format. The conversion back to a character may banjax the SEARCH. I don't have time to test that right now, so marking for feedback from Kenneth

CC

I did not have time to test this. Give me a few more days.

-- TWiki:Main.KennethLavrsen - 02 Jan 2008

Thanks for fixing / expanding on this. Havent stumbled into new issues with this latest behaviour.

-- TWiki:Main.SteffenPoulsen - 03 Jan 2008

Did a brief test and did not see anything.

I have now out the corrected Wysiwyg in production on our live server.

I will monitor all changed topics the next days and report if I see problems. With things like these the innovative level of surprising user behavior among 300 engineers is the best way to test this. Will report back in a few days (will monitor the weekend where traffic is lower and Monday)

Will also update my Motion site and activate Wysiwyg again there.

-- TWiki:Main.KennethLavrsen - 04 Jan 2008

I have run with this for a few days but because of the Item5218 I am not able to say if this problem is totally solved.

-- TWiki:Main.KennethLavrsen - 07 Jan 2008

No further negative reports from this. Closing

-- TWiki:Main.KennethLavrsen - 11 Jan 2008

Re-opening, as the fix has at least partially caused Item5294.

-- CrawfordCurrie - 28 Mar 2008

Reverted the angle-brace change.

CC