Item5130: Clicking "Upload" when changing properties gives sub-optimal result

If you click "manage" in the attachments table, you get a screen with an empty file path. if you then click "Add link" or "Hide file" and click "Upload" by mistake, then you get a stack dump.

Use of uninitialized value in hash element at (eval 95) line 3.
 at /home/twiki/MAIN/lib/TWiki/UI.pm line 84
   TWiki::UI::__ANON__('Use of uninitialized value in hash element at (eval 95) line 3.\x{a}') called at (eval 95) line 3
   CGI::tmpFileName('CGI=HASH(0x8247af8)', '') called at /home/twiki/MAIN/lib/TWiki/UI/Upload.pm line 193
   TWiki::UI::Upload::upload('TWiki=HASH(0x847e2cc)') called at /home/twiki/MAIN/lib/TWiki/UI.pm line 159
   TWiki::UI::__ANON__() called at /usr/local/share/perl/5.8.8/Error.pm line 426
   eval {...} called at /usr/local/share/perl/5.8.8/Error.pm line 418
   Error::subs::try('CODE(0x814ed30)', 'HASH(0x881b708)') called at /home/twiki/MAIN/lib/TWiki/UI.pm line 197
   TWiki::UI::run('CODE(0x82da534)') called at /home/twiki/MAIN/bin/upload line 32.

-- TWiki:Main/CrawfordCurrie - 14 Dec 2007

You do? I get the message Either you did not specify a file name, or the file you are trying to upload "" has no content. You may not upload an empty file.

-- TWiki:Main.ArthurClemens - 14 Dec 2007

It is trivial to reproduce in this topic.

1. Click "manage" for the attachment "afa.mid" in the attachments table
2. Click "Upload file"

CC

See also Item5133, which has the same stack trace.

-- TWiki:Main.CrawfordCurrie - 15 Dec 2007

Fixed by wrapping an exception handler around the tmpFileName call.

CC