Item5108 < Bugs

• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use

Item7848 for generic doc work for TWiki-6.1.1. Use

Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Engine	Performance	Enhancement	Closed		patch

Because of an incomplete refactoring, all calls to plugin handlers indirect via the plugins object. This makes sense in a statically comiled language, but in an interpreted language like perl it is dumb. For example,

$twiki->{plugins}->commonTagsHandler(...)

is implemented as

sub commonTagsHandler { 
   my $this = shift ;
    $this->_dispatch('commonTagsHandler', @_);
}

All the handlers are implemented the same way. This slows down the code in two ways; because of the indirection, but also because of all the extra code that has to be compiled. It also makes adding a new handler a painful process.

Get rid of the indirection and call the dispatcher direct. It also makes the code clearer.

-- TWiki:Main/CrawfordCurrie - 10 Dec 2007

Done in MAIN; mark as "waiting for release" when 4.2.0 is gone.

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary	Get rid of indirection in plugin handler calls
ReportedBy	TWiki:Main.CrawfordCurrie
Codebase
SVN Range	TWiki-4.3.0, Sun, 25 Nov 2007, build 15790
AppliesTo	Engine
Component	Performance
Priority	Enhancement
CurrentState	Closed
WaitingFor
Checkins	TWikirev:16003 TWikirev:16034
TargetRelease	patch
ReleasedIn

Item5108: Get rid of indirection in plugin handler calls

Item Form Data

Edit Form Data

Detail