Item5091: User mapping does not map login to wikiname on old revisions of topics when using HistoryPlugin

When you look at earlier revisions of topics you cannot see who edited them

At least not in the configuration where you map login ID to wikinames.

The strange thing is that the user is shown at the bottom of the topic but not at the top and not in the revision history you see in the history plugin.

Examples

http://merlin.lavrsen.dk/twiki42/bin/view/Myweb/WebHome?rev=8

http://merlin.lavrsen.dk/twiki42/bin/oops/Myweb/WebHome?template=oopshistory

-- TWiki:Main/KennethLavrsen - 06 Dec 2007

In the error log I have lots of

[Thu Dec 06 23:34:37 2007] [error] [client 124.168.137.74] Use of uninitialized value in string eq at /usr/local/apache2/twiki42/lib/TWiki/Users/TWikiUserMapping.pm line 409., referer: http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs/Item5091 [Thu Dec 06 23:34:37 2007] [error] [client 124.168.137.74] Use of uninitialized value in string eq at /usr/local/apache2/twiki42/lib/TWiki/Users/TWikiUserMapping.pm line 512., referer: http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs/Item5091

which may explain things

-- TWiki:Main.KennethLavrsen - 06 Dec 2007

pretty much another make the code do what the docco says, and write the docco job.

-- SvenDowideit - 07 Dec 2007

I have to reopen this one

After I have installed the 4.2.0 RC2 at Motorola all our history shows the editor of all revisions generated before the 4.2.0 RC2 as a link to the wikiname in the current web instead of the Main web.

The reason is that in the old days 4.1.2 and earlier it was the wikiname that was stored in the ,v files. Now it is the login name. So all revisions not being the login name are not mapped to the wikiname and we end up with wrong links to wikinames.

Sven, you need to give this another go.

I have confirmed that the problem is still there in the current code.

-- KennethLavrsen - 15 Dec 2007

I have uploaded https://mail.twiki.org/pub/Bugs/Item5091/TestTopic19.zip with a file that shows the problem. To see the problem add a line in TWikiUsers that says

   * KennethLavrsen - c12179 - 01 Oct 2007

and make a topic in Main called KennethLavrsen

And naturally run TWiki with ApacheLogin and no password manager.

-- TWiki:Main.KennethLavrsen - 15 Dec 2007

Actually this one is not really a user mapping error.

TWiki::Func::userToWikiName has a 2nd parameter called $dontAddWeb.

When the mapper finds the user it prefix correctly with Main.

But when it cannot find the user it does not prefix the login ID with Main.

But if the plugin author requested the web name to be included then Func should add it no matter what. This way old topics where the wikiname is stored instead of the login ID will still be reported correctly in plugins such as HistoryPlugin.

Unless someone objects I can fix this in func.

-- TWiki:Main.KennethLavrsen - 17 Dec 2007

I convinced myself that the fix is right. Unittests pass.

-- TWiki:Main.KennethLavrsen - 17 Dec 2007