Item4250: Pipe symbol (i.e. in SEARCH) breaks Form Definition Table

http://twiki.org/cgi-bin/view/Support/UnmatchedBracketInRegexVarSEARCH

-- TWiki:Main/FrankSpangenberg - 15 Jun 2007

Form::_parseFormDefinition splits the line on every pipe symbol and handles tags afterwards (in the value-column). This works well, if the author doesnt want to use the pipe symbol i.e. within a SEARCH tag (as a logical OR).

Proposal: call handleCommonTags() before splitting. - Any ideas why this might be a bad idea?

-- TWiki:Main/OliverKrueger - 15 Jun 2007

Oh boy, what a can of worms.

Proposal: call handleCommonTags() before splitting. - Any ideas why this might be a bad idea?

How about when a variable used in the table expands to a value that includes a '|'? Or a newline?

I don't think that would work. How about better handling of \ as an escape character? At the moment only \\n is handled; why not \| as well (even better, use \ as a general escape in form definitions)

CC

Is there more to do than adding a new escape regex to TWiki.pm? I tried adding a new line replacing $pipe with |, but it doesn't work... it wasn't replaced.

-- TWiki:Main.FrankSpangenberg - 16 Jun 2007

There is no $pipe escape, as you discovered (that was really wishful thinking on your part).

This should be resolved by generalised escapes that prevent \| being interpreted as a table column separator in the form parser. Fix in Form.pm

CC

I added \| as an escape for the pipe symbols in form definitions.

CC