The upgrade emails script is now totally broken.

It is supposed to copy the email address from the user topics into the secret password file.

And when there is no email address it should use the admin address.

But only if there is no secret email address already.

Now it overwrites all the perfectly OK stored secret email addresses with the admin address.

It also has a small glitch when it prompts for the admin email address. It prompts once more.

KJL

It prompts once more, a visual confirmation of correct input. It's kind of a "one-time" operation, no way to automatically revert to another admin address once inserted, I thought an extra check wouldn't hurt before proceeding.

• Extra check would be OK if it asked to confirm. But just repeating the same input line is unusual and my reaction was that it did not accept my input. KJL

Strange, cannot verify behaviour with overwrite of already stored e-mails - test data?

What password manager are you using - one that'll actually read the email from .htpasswd?

-- SP

I am using the normal Apache authentication with a .htpasswd file. Otherwise I would not need to run the upgrade_emails.pl script in the first place.

You need a .htpasswd file with some users that have the email address stores.

And the same user with a topic without an email address.

The tool should leave this user alone and not alter his email address in .htpasswd.

KJL

Can't reproduce this. User e-mails for users with no e-mail listed in their user topics (but having one already in .htpasswd) are left untouched here.

What wording would you like in the script, to clear things up?

-- SP

Changed wording, still can't reproduce - closing this. This is with HtPasswdUser / TemplateLogin.

SVN 1492.

-- SP

I can not make it fail either. I must have made a mistake when I tested. Red Herring. Thanks. Your fix for the prompt text is fine. Thank you for that.

KJL