I intially asked this in the support web
http://twiki.org/cgi-bin/view/Support/METAformfieldDisplayBroken
After upgrading from 4.1.2 to 4.2, META tags for form fields came up blank and didn't work
Looking in the Twiki.pm for 4.2 shows that the function that renders the formfield has changed from 4.1
I was able to restore functionality using the following change:
--- lib/TWiki.pm 2008-04-23 13:06:50.000000000 +1000
+++ lib/Twiki.pm.orig 2008-04-23 13:37:42.000000000 +1000 @@ -3795,7 +3795,7 @@
return $meta->renderFormForDisplay( $this->templates );
} elsif ( $option eq 'formfield' ) {
# a formfield from within topic text
- return $meta->renderFormFieldForDisplay( $params->{'name'}, '$value' );
+ return $meta->renderFormFieldForDisplay( $params );
} elsif( $option eq 'attachments' ) {
# renders attachment tables
return $this->attach->renderMetaData( $web, $topic, $meta, $params );
So I have some questions:
- Is this a Bug?
- Is this a good fix for it?
- Should the fix be on the renderFormFieldForDisplay function in Meta.pm and not the Twiki.pm?
- The renderFormFieldForDisplay function appears to be called correctly from /ActionTrackerPlugin/Action.pm and the Search.pm.
--
TWiki:Main/SimonHarrison - 03 Jun 2008
odd - I'll have to look into why it was changed.
--
TWiki:Main.SvenDowideit - 03 Jun 2008
http://develop.twiki.org/trac/changeset/16770
--
TWiki:Main.CrawfordCurrie - 03 Jun 2008
What Crawford means to say, is that this has already been patched for 4.2.1 - though I'm surprised that
Item4741 didn't examine the root cause.
--
TWiki:Main.SvenDowideit - 03 Jun 2008
Sorry, I was a bit terse there....
--
TWiki:Main.CrawfordCurrie - 03 Jun 2008
and so presumably, its fixed
--
SvenDowideit - 25 Jun 2008